Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Leverage requests session object for network level retry management #183

Merged
merged 43 commits into from
May 13, 2024

Conversation

joshburt
Copy link
Contributor

@joshburt joshburt commented Jan 26, 2024

What

  • Added network response retries to requests session object.
  • Added support for Cloudflare auth headers
  • System and Load tests migrated to dedicated repository.

Why

  • Add Cloudflare header support to allow access to AE5 running behind CloudFlare.
  • Handling network level calls was updated to reduce the incident of failures when accessing AE5 in slow environments.
  • cli response parsing changed from csv -> json, to json -> json. This affected several truth and datetime comparisons within the tests - but allows for proper dictionary comparisons.

How was this tested

  • Unit Tests
  • Integration Tests

These can now be watched in https://github.com/Anaconda-Platform/anaconda-platform-system-test/pull/1

To test this PR:

  1. Create two environment variables:
    CF_ACCESS_CLIENT_ID & CF_ACCESS_CLIENT_SECRET
    These need to be filled with valid credentials for our CloudFlare organization. Reach out if you need assistance getting access.
  2. Disconnect the W.A.R.P. client.
  3. Execute the system tests: anaconda-project run test:system.

The tests will not be able to access the CloudFlare protected instances unless the CF env vars are set.

@joshburt joshburt marked this pull request as ready for review May 10, 2024 22:49
@joshburt joshburt merged commit 6ea9f3f into master May 13, 2024
1 check passed
@joshburt joshburt deleted the jb_retries branch May 13, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants