Only avoid logging KeyboardInterrupt's

[nathanwilk7]

I've had some trouble lately with silent anaconda-client errors, so I started looking through the code to find the cause. I found that the issue was that the excepthook function returns without logging for all errors besides ServerError's. It seems possible to me that the intent here may have actually been to return without logging for only KeyboardInterrupt and ServerError, in which case let me know and I can just take out the not, but personally I don't see any reason to hide ServerError's from the user.

I'm proposing the following change based on my assumption that the desired behavior is to display the error message and error code to the user. If the desired behavior here is different than I assume, please let me know and I'd be happy to make whatever changes you suggest (including if there are any exception messages that may need to be more user friendly).

Before

anaconda-client:master$ python binstar_client/scripts/cli.py -t asdf upload -u myusername /path-to-build-output/build_output.tar.bz2
...
Uploading file "/path-to-build-outupt/osx-64/build_output.tar.bz2"
[WARNING] Distribution "osx-64/build_output.tar.bz2" already exists. Removing.

After (note the [ERROR] at the end)

anaconda-client:master$ python binstar_client/scripts/cli.py -t asdf upload -u myusername /path-to-build-output/build_output.tar.bz2
...
Uploading file "/path-to-build-outupt/osx-64/build_output.tar.bz2"
[WARNING] Distribution "osx-64/build_output.tar.bz2" already exists. Removing.
[ERROR] ('Authorization token is no longer valid', 401)

Related Issues

• anaconda upload silently fails #501
• anaconda-client gives up, seemingly randomly. #492
• Issue with upload command aborting silently #418

[nathanwilk7]

@goanpeca Friendly bump on this, are you the current maintainer of this project?

[nathanwilk7]

Closed in favor of #507