Merge pull request #19 from Anaconda-Platform/jb_long_wait

Remove timeout for loopback health call
anaconda · Oct 3, 2023 · 77f3b54 · 77f3b54
2 parents 3a98c99 + 03b7bb0
commit 77f3b54
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/mlflow_adsp/services/endpoint_manager.py b/mlflow_adsp/services/endpoint_manager.py
@@ -103,7 +103,7 @@ def _poll_network_service(self, process: subprocess.Popen) -> bool:
 
         try:
             version_endpoint_url: str = f"http://{self.params.host}:{self.params.port}/version"
-            response: Response = requests.get(url=version_endpoint_url, timeout=1)
+            response: Response = requests.get(url=version_endpoint_url)
             if response.status_code != 200:
                 logger.debug("Service not yet healthy, waiting ..")
                 EndpointManager._proc_comm(process=process, timeout=self.params.timeout)

diff --git a/test/unit/services/test_endpoint_manager.py b/test/unit/services/test_endpoint_manager.py
@@ -386,7 +386,7 @@ def test_poll_network_service_gracefully_fails(monkeypatch):
     client: MagicMock = MagicMock()
     monkeypatch.setattr(subprocess, "Popen", MockPOpen)
 
-    def mock_get(url, timeout):
+    def mock_get(url):
         raise requests.exceptions.ConnectionError("Boom!")
 
     monkeypatch.setattr(requests, "get", mock_get)