Adding more multiline string support #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuylermartin45
requested review from
beeankha,
JeanChristopheMorinPerso and
Arishamays1
|
The |
|
@wolfv The last commit has that sorting we talked about earlier today, if you were curious ^ |
- Expands support past the `|` character to include the 6 common variants
found in our recipe files (`|`, `|+`, `|-`, `>`, `>+`, `>-`)
- For our purposes, the meaning of these symbols is not super important for
parsing and rendering the YAML files. The next commit will ensure returning
the multiline string works as expected per symbol.
- Adds unit tests
- Multiline strings are now interpreted correctly in `get_value()` and `render_to_object()` - Multiline strings containing JINJA substitutions will now correctly subsitute those values - Adds more unit tests, including some missing coverage of edge cases
- This should mask any "odd" orderings caused by the patch operations required to switch to the new format. - Ordering follows a "canonical" sorting. This is what most recipe builders are comfortable and used to seeing. - Ordering was a group effort in our Conda Build Tools chatroom
schuylermartin45
force-pushed
the
smartin_PAT-25
branch
from
5a8147a to
a44316e
Compare
beeankha
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recipe parser now properly handles multiline strings when
|and>(plus+/-) variants are used. Previously the parser only supported the|character.The bulk of this PR includes additional unit testing.
I also took the time to sort the top-level YAML keys in a "canonical" order.
See commits for additional details.