Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util_axis_fifo: Fix tkeep signal value when KEEP_EN is 0 #1455

Merged
merged 2 commits into from
Nov 22, 2024
Merged

util_axis_fifo: Fix tkeep signal value when KEEP_EN is 0 #1455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b93a02f
util_axis_fifo: Fix tkeep signal value when KEEP_EN is 0
IstvanZsSzekely Sep 11, 2024
79fc8d8
util_axis_fifo: Set tkeep and tlast values to 1 as the standard requires
IstvanZsSzekely Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions library/util_axis_fifo/util_axis_fifo.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ module util_axis_fifo #(
end
assign m_axis_tlast = axis_tlast_d;
end else
assign m_axis_tlast = 'b0;
assign m_axis_tlast = 1'b1;

// TKEEP support
if (TKEEP_EN) begin
Expand All @@ -162,7 +162,7 @@ module util_axis_fifo #(
end
assign m_axis_tkeep = axis_tkeep_d;
end else
assign m_axis_tkeep = {DATA_WIDTH/8{1'b1}};
assign m_axis_tkeep = ~0;

end /* zerodeep */
else
Expand Down Expand Up @@ -206,7 +206,7 @@ module util_axis_fifo #(
end
assign m_axis_tlast = axis_tlast_d;
end else
assign m_axis_tlast = 'b0;
assign m_axis_tlast = 1'b1;

// TKEEP support
if (TKEEP_EN) begin
Expand All @@ -221,7 +221,7 @@ module util_axis_fifo #(
end
assign m_axis_tkeep = axis_tkeep_d;
end else
assign m_axis_tkeep = {DATA_WIDTH/8{1'b1}};
assign m_axis_tkeep = ~0;

end /* !ASYNC_CLK */

Expand Down Expand Up @@ -289,17 +289,17 @@ module util_axis_fifo #(
end else if (TKEEP_EN) begin
assign s_axis_data_int_s = {s_axis_tkeep, s_axis_data};
assign m_axis_tkeep = m_axis_data_int_s[MEM_WORD-1-:DATA_WIDTH/8];
assign m_axis_tlast = 'b0;
assign m_axis_tlast = 1'b1;
assign m_axis_data = m_axis_data_int_s[DATA_WIDTH-1:0];
end else if (TLAST_EN) begin
assign s_axis_data_int_s = {s_axis_tlast, s_axis_data};
assign m_axis_tkeep = {DATA_WIDTH/8{1'b1}};
assign m_axis_tkeep = ~0;
assign m_axis_tlast = m_axis_data_int_s[DATA_WIDTH];
assign m_axis_data = m_axis_data_int_s[DATA_WIDTH-1:0];
end else begin
assign s_axis_data_int_s = {s_axis_data};
assign m_axis_tkeep = {DATA_WIDTH/8{1'b1}};
assign m_axis_tlast = 'b0;
assign m_axis_tkeep = ~0;
assign m_axis_tlast = 1'b1;
assign m_axis_data = m_axis_data_int_s[DATA_WIDTH-1:0];
end

Expand Down
Loading