Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects: Fix project name for pulsar_adc and ad411x_ad717x #1554

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

IuliaCMoldovan
Copy link
Contributor

PR Description

Fixed the project name set in Tcl and Makefile for pulsar_adc and ad411x_ad717x to match the folder name + _carrier.

pulsar_adc_pmdz_coraz7s -> pulsar_adc_coraz7s
pulsar_adc_pmdz_zed -> pulsar_adc_zed
ad411x_de10nano -> ad411x_ad717x_de10nano

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

* Changed from pulsar_adc_pmdz to pulsar_adc as the folder name

Signed-off-by: Iulia Moldovan <[email protected]>
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's wait the CI to finish to ensure nothing breaks down the pipeline

@IuliaCMoldovan
Copy link
Contributor Author

@gastmaier The affected projects (ad411x_ad717x.de10nano, pulsar_adc.coraz7, pulsar_adc.zed) passed with success.

@IuliaCMoldovan IuliaCMoldovan merged commit b064ed8 into main Jan 15, 2025
3 of 5 checks passed
@IuliaCMoldovan IuliaCMoldovan deleted the fix_prj_name branch January 15, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants