Misc improvements #1245
Open
Misc improvements #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunojsa
requested review from
cristina-suteu,
dNechita and
mhennerich
as code owners
|
Ups, I was testing this with other patches (part of open PRs)... But this should still work without them. I'll drop the unneeded commits. |
Make sure to dequeue any possible in flight block before destroying it. Note that if the block is not enqueued, this returns an error but we really don't care about it. Making sure the block is dequeued makes for a much cleaner exit specially in cases where freeing the blocks is deferred to the default client. Signed-off-by: Nuno Sá <[email protected]>
When destroying the stream, we'll try to dequeue (as it improves things on iiod side) any possible pending block and if the buffer is already cancelled we'll just timeout and make exiting the app much slower. Hence, let's try a clean exit first and if we get blocked a second hit on ctrl-c will go and cancel the buffer as before. Signed-off-by: Nuno Sá <[email protected]>
nunojsa
force-pushed
the
staging/misc-improv
branch
from
e29e5d3 to
f615c07
Compare
|
I have been running a "quick" test on Windows for a while now. However, I haven't been able to test your changes yet due to some issues with the MSVC 2019 build. The issue occurs both with my local build and with the artifacts from Azure and I am trying to figure out what is causing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This improves iio_rwdev exit and is a combination of two things:
So this is really a combination of the above two points which improves things a lot when cancelling a buffer session with iio_rwdev.
Note this is only tested on linux so it would be great if someone could do a quick test on windows.
PR Type
PR Checklist