Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] missed inlines in C++ binding #1247

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

topin89
Copy link
Contributor

@topin89 topin89 commented Feb 18, 2025

PR Description

Missed inline keyword before a couple of functions in bindings/cpp/iiopp.h . Since I included it in two .cpp files and no more "multiple definitions", that should be all missed inlines.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked that I did not intoduced new warnings or errors (CI output)
  • I have checked that components that use libiio did not get broken
  • I have updated the documentation accordingly (GitHub Pages, READMEs, etc)

After fixing these lines, gcc stopped showing multiple definition errors, so I'm sure no more missed `inline`s left

Signed-off-by: Mikhail Gorodetskiy <[email protected]>
Copy link
Contributor

@dNechita dNechita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the fix!

@dNechita dNechita merged commit e54973a into analogdevicesinc:main Feb 19, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants