Add support for ADUM770x/78xx #2698
Open
+367
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pop Ioan Daniel <[email protected]>
Signed-off-by: Pop Ioan Daniel <[email protected]>
PIoandan
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
nunojsa
reviewed
Jan 22, 2025
| @@ -54,6 +54,7 @@ config IIO_ALL_ADI_DRIVERS | |||
| imply AD7923 | |||
| imply AD7944 | |||
| imply AD7949 | |||
| imply AD7405 | |||
There was a problem hiding this comment.
This should a separate patch
| help | ||
| Say yes here to build support for Analog Devices AD7405 | ||
| high speed, low noise, low distortion, 16-bit, Sigma- | ||
| Delta modulator. Provides direct access via sysfs. |
There was a problem hiding this comment.
also a separate patch... please do not mix code with devicetree stuff
| #include <linux/iio/buffer-dma.h> | ||
| #include <linux/iio/buffer-dmaengine.h> | ||
|
|
||
| #include <linux/fpga/adi-axi-common.h> |
There was a problem hiding this comment.
Not seeing any reason for not being used the new backend framework to support this part. SO that we can actually upstream this
| static struct iio_chan_spec_ext_info ad7405_ext_info[] = { | ||
|
|
||
| IIO_ENUM("dec_rate", IIO_SHARED_BY_ALL, &ad7405_dec_rate_iio_enum), | ||
| IIO_ENUM_AVAILABLE("dec_rate", IIO_SHARED_BY_ALL, &ad7405_dec_rate_iio_enum), |
There was a problem hiding this comment.
Is this somehow affecting the sampling frequency? In some other parts where we can decimate the ODR, this is implemented with the standard sampling frequency attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Driver support and devicetree files for the ADUM770x/78xx ADCs
Datasheet: ADUM7701
PR Type
PR Checklist