fix(Other): Zephyr: MAX32650: Add missing LP wrappers #1344
Conversation
| @@ -50,7 +51,11 @@ static inline void Wrap_MXC_LP_EnterStandbyMode(void) | |||
|
|
|||
| static inline void Wrap_MXC_LP_EnterPowerDownMode(void) | |||
| { | |||
| #if defined(CONFIG_SOC_MAX32650) | |||
| MXC_LP_EnterBackupMode(); | |||
There was a problem hiding this comment.
I think this is not correct mode for this function. According to user guide, there is "Shutdown Mode" for MAX32650 too.
Also, there are macros for this mode.
Maybe you should create a new "MXC_LP_EnterShutdownMode(...)" function in lp_me10.c file.
There was a problem hiding this comment.
Mb, didn't realize we could touch those as well. Was trying the best fit with what was provided while only touching the wrapper files. Looking into it.
Burakbabao
force-pushed
the
fix-MAX32650-lp-wrapper
branch
from
518025e to
658a9c4
Compare
Burakbabao
force-pushed
the
fix-MAX32650-lp-wrapper
branch
from
658a9c4 to
acd0650
Compare
|
Have you tested this on a board? |
Burakbabao
force-pushed
the
fix-MAX32650-lp-wrapper
branch
2 times, most recently
from
ca9dc13 to
ac204f8
Compare
Burakbabao
force-pushed
the
fix-MAX32650-lp-wrapper
branch
from
ac204f8 to
3a05c74
Compare
Soo, the shutdown function bricked two boards. @hfakkiz although there is a shutdown mode and the relevant GCR info in the documentation, there seems to be an issue with it. So, for now, the backup function was used. The issue may be found if the conflicting declarations of the shutdown mode bits are investigated more: shutdown declared b011 on page67 of user guide 32650: shutdown declared b111 on page53 of user guide 32650: |
This commit adds the missing lp define for MAX32650 for the zephyr build system. The shutdown function was seen to be problematic so the similar backup function was used for now. Signed-off-by: Burak Babaoglu <[email protected]>
Burakbabao
force-pushed
the
fix-MAX32650-lp-wrapper
branch
from
3a05c74 to
9d4b53d
Compare
This commit adds the missing Low Power defines for MAX32650 for the zephyr build system.
There are generally two main groups in the wrap_max32_xx files. MAX32650 fits the first group for Low Power. However, there is no MXC_LP_EnterShutDownMode() function provided for MAX32650 so the MXC_LP_EnterBackupMode() function was chosen as best fit.