Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for ADF4382 #626

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add Support for ADF4382 #626

wants to merge 17 commits into from

Conversation

Jude-Osems
Copy link
Collaborator

Description

Add adf4382.py driver
Add example script for example_adf4382.py
Update index.rst, init.py, supported_parts.md files

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware: ADF4382 Evaluation Board
  • RTOS: No-OS

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

chegbeli and others added 17 commits September 27, 2023 14:28
In the driver reference_doubler has been renamed to reference_doubler_en.

Signed-off-by: chegbeli <[email protected]>
The IIO attribute list has been updated and the python support for the
ADF4382 had to have a corresponding update as well

Signed-off-by: chegbeli <[email protected]>
The IIO attribute list has been updated, the example file has also
been updated to match the new names and expected values.

Signed-off-by: chegbeli <[email protected]>
There are some cases where driver will have different attributes based
on Linux vs No-OS solutions. In order to have a unified test for both
scenarios, this marker will be used to differentiate between them.

Signed-off-by: chegbeli <[email protected]>
This will test out the ranges of the IIO attributes which can be read
form the register space. Some attributes are only present in the No-OS
solution and require the use of the No-OS marker.

Signed-off-by: chegbeli <[email protected]>
Signed-off-by: chegbeli <[email protected]>
Signed-off-by: chegbeli <[email protected]>
Added the debug attributes for direct register access over the IIO
interface.

Signed-off-by: chegbeli <[email protected]>
Added the debug example for direct register access over the IIO
interface.

Signed-off-by: chegbeli <[email protected]>
@Jude-Osems Jude-Osems requested a review from tfcollins January 24, 2025 16:36
Copy link

github-actions bot commented Jan 24, 2025

Test Results

1 611 tests  +12     402 ✅ ± 0   12m 6s ⏱️ ±0s
    1 suites ± 0   1 209 💤 +12 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 945067b. ± Comparison against base commit c7c4ca6.

This pull request removes 4 and adds 16 tests. Note that renamed tests count towards both.
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[1.5, 13.0, 19.5, 17.5, 2.0, 31.0, 6.0, 9.0, 21.5, 8.0]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[9.5, 0.5, 20.5, 9.5, 27.5, 26.5, 22.5, 16.5, 27.5, 16.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-37.35, -22.8, -32.7, -1.2, -31.85, -21.1, -31.1, -26.15, -29.95, -16.55]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-29.75, -21.7, -18.55, -36.85, -2.5, -19.8, -38.05, -2.4, -31.65, -33.9]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]
test.test_adf4382 ‑ test_adf4382_attrs[attr=altvolt0_output_power-start=1-stop=11-step=1-tol=0-repeats=5-classname=adi.adf4382]
test.test_adf4382 ‑ test_adf4382_attrs[attr=altvolt1_output_power-start=1-stop=11-step=1-tol=0-repeats=5-classname=adi.adf4382]
test.test_adf4382 ‑ test_adf4382_attrs_bool[attr=altvolt0_en-value=0-classname=adi.adf4382]
test.test_adf4382 ‑ test_adf4382_attrs_bool[attr=altvolt0_en-value=1-classname=adi.adf4382]
test.test_adf4382 ‑ test_adf4382_attrs_bool[attr=altvolt1_en-value=0-classname=adi.adf4382]
test.test_adf4382 ‑ test_adf4382_attrs_bool[attr=altvolt1_en-value=1-classname=adi.adf4382]
test.test_adf4382 ‑ test_adf4382_attrs_bool_no_os[attr=reference_doubler_en-value=0-classname=adi.adf4382]
test.test_adf4382 ‑ test_adf4382_attrs_bool_no_os[attr=reference_doubler_en-value=1-classname=adi.adf4382]
test.test_adf4382 ‑ test_adf4382_attrs_bool_no_os[attr=sw_sync_en-value=0-classname=adi.adf4382]
test.test_adf4382 ‑ test_adf4382_attrs_bool_no_os[attr=sw_sync_en-value=1-classname=adi.adf4382]
…

♻️ This comment has been updated with latest results.

Copy link

Generated documentation for this PR is available at Link

@tfcollins tfcollins self-assigned this Jan 25, 2025
@tfcollins tfcollins added the enhancement New feature or request label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants