Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferences: add description to preferences and autogenerate the docs #1869

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlexandraTrifan
Copy link
Contributor

@AlexandraTrifan AlexandraTrifan commented Dec 20, 2024

All the preferences now require a description and are created
using function macros in order to parse and automatically detect all.

Signed-off-by: AlexandraTrifan <[email protected]>
@AlexandraTrifan AlexandraTrifan marked this pull request as ready for review January 23, 2025 15:04
@AlexandraTrifan AlexandraTrifan changed the title wip: add description to preferences and try to autogenerate the docs preferences: add description to preferences and try to autogenerate the docs Jan 23, 2025
@AlexandraTrifan AlexandraTrifan changed the title preferences: add description to preferences and try to autogenerate the docs preferences: add description to preferences and autogenerate the docs Jan 23, 2025
Comment on lines +284 to +285
"the current state of the application."
"Important messages such as connection done or alerts are displayed here.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space must be placed after application.

Comment on lines +289 to +290
"Indicates whether the plot grid is visible across the application."
"The user can enable or disable this in order to configure the ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space missing.

Comment on lines +305 to +306
"Indicates whether native dialogs should be used in the application."
"This setting allows the user to enable or disable the use of native file "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space missing.

Comment on lines +313 to +314
"Scale factor for the font size used across the application, suitable for "
"different display settings",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period at the end.

Comment on lines +318 to +319
"Theme setting for the application interface."
"The user can choose between Harmonic style (light or dark) or Scopy style.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space

Comment on lines +329 to +330
"to handle them separately using different sections in the left side menu."
"Due to not being tested using enough scenarios it is still marked as an experimental feature.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space.

Comment on lines +318 to +319
"Enable/disable the configuration panel for ADC digital filters."
"This allows manual control over the parameters of the filters.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space.

Comment on lines +342 to +343
"Select whether the 0dB value is displayed as a reference point on the"
"Network Analyzer plot. This control is disabled by default.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include space between "the" and "Network".

Comment on lines +347 to +348
"Select the number of displayed signal periods in the Signal Generator."
"Default value is 2.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include space between sentences.

Comment on lines +122 to +123
"Select whether the Y-Axis handle is located on the left or right side of the plot."
"Only applied after restart.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include space between sentences.

Comment on lines +130 to +131
"Select whether the X-Axis cursor handles are located on the top or bottom of the plot."
"Only applied after restart.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include space between sentences.

Comment on lines +138 to +139
"Select whether the Y-Axis cursor handles are located on the left or right side of the plot."
"Only applied after restart.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include space between sentences.

Comment on lines +146 to +147
"%Full Scale. This is also controllable while running, from the instrument settings."
"Only applied after restart.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include space between sentences.

Copy link
Contributor

@bindea-cristian bindea-cristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text displayed by the info button can be hard to read if it's too long.
One way to improve readability would be to add in a few places an "\n".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants