Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exclusions check for better new user experience #412

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Update exclusions check for better new user experience #412

merged 7 commits into from
Oct 18, 2024

Conversation

HN23
Copy link
Member

@HN23 HN23 commented Oct 10, 2024

fail if:
Doing an upgrade AND:

  • previously had an excluded driver using values
  • previous had an extraEnv with the variable name "ANCHORE_FEEDS_DRIVER
  • previously did not install Anchore with feeds.chartEnabled

@HN23 HN23 requested a review from a team as a code owner October 10, 2024 21:23
@HN23
Update exclusions check to only fail under certain conditions. extern…
7606537 
…al feeds, disabled drivers

Signed-off-by: Hung Nguyen <[email protected]>
@HN23
toJson the list
1f2bbe4 
Signed-off-by: Hung Nguyen <[email protected]>
@HN23
test updates
e7c9d1b 
Signed-off-by: Hung Nguyen <[email protected]>
InfraInnovator
InfraInnovator previously approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@InfraInnovator InfraInnovator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@HN23
updating tests
c8a2286 
Signed-off-by: Hung Nguyen <[email protected]>
Btodhunter
Btodhunter previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@Btodhunter Btodhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested the following:

  • feeds chart disabled & no providers/packages specified -> failed w/ warning

  • feeds chart enabled & global extraEnv gem/msrc/github drivers disabled & no providers/packages specified -> failed w/ warning

  • feeds chart enabled & feeds extraEnv gem/msrc/github drivers disabled & no providers/packages specified -> failed w/ warning

  • feeds chart enabled & feeds.anchoreConfig.drivers.gem/msrc/github disabled & no providers/packages specified -> failed w/ warning

  • feeds chart disabled & providers/packages specified -> successful upgrade

  • feeds chart enabled & global extraEnv gem/msrc/github drivers disabled & providers/packages specified -> successful upgrade

  • feeds chart enabled & feeds extraEnv gem/msrc/github drivers disabled & providers/packages specified -> successful upgrade

  • feeds chart enabled & feeds.anchoreConfig.drivers.gem/msrc/github disabled & providers/packages specified -> successful upgrade

  • fresh install of 3.0.1 chart with no providers/packages specified -> successful install

  • fresh install of 3.0.1 chart with providers/packages specified -> successful install

stable/enterprise/templates/_helpers.tpl Show resolved Hide resolved
stable/enterprise/templates/_helpers.tpl Show resolved Hide resolved
@HN23 HN23 merged commit c00f218 into main Oct 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Btodhunter Btodhunter Btodhunter approved these changes

@InfraInnovator InfraInnovator InfraInnovator left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HN23 @Btodhunter @InfraInnovator