#166840979 Implement articles search by tag (tag) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| <h3 className="mb-3 articles-title">{singleArticle.title}</h3> | ||
| <p className="card-text mb-3">{`${singleArticle.body.substring(0, 150)}...`}</p> | ||
| <div className="d-flex flex-row articles-feature"> | ||
| <p className="articles-like mr-3"> |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
codeBlock-1984
force-pushed
the
ft-search-articles-by-tag-166840979
branch
from
be8714e
to
cb4d01b
Compare
czarjulius
approved these changes
Sep 2, 2019
chokonaira
approved these changes
Sep 2, 2019
Alpha1202
approved these changes
Sep 2, 2019
codeBlock-1984
force-pushed
the
ft-search-articles-by-tag-166840979
branch
from
cb4d01b
to
87a1aeb
Compare
fob413
reviewed
Sep 3, 2019
_test_/ArticleActions.spec.js
Outdated
| it('fetches articles', () => { | ||
| moxios.wait(() => { | ||
| const request = moxios.requests.mostRecent(); | ||
| // console.log(request); |
fob413
reviewed
Sep 3, 2019
_test_/ArticleActionsTag.spec.js
Outdated
| .then(() => { | ||
| const actionsCalled = store.getActions(); | ||
| expect(actionsCalled).toEqual(expectedActions); | ||
| // expect(actionsCalled[1].type).toEqual(GET_ARTICLES_BY_TAG); |
fob413
reviewed
Sep 3, 2019
| @@ -59,8 +60,9 @@ const App = () => ( | |||
| <Route path="/newpassword" component={PasswordReset} /> | |||
| <Route path="/socialAuth" component={SocialAuth} /> | |||
| <Route path="/article" component={CreateArticlePage} /> | |||
| <Route path="/articles" component={Articles} /> | |||
| <Route path="/articles/:slug" component={SingleArticle} /> | |||
| <Route exact path="/articles" component={Articles} /> | |||
There was a problem hiding this comment.
Remove exacts from the routes
There was a problem hiding this comment.
Hi @fob413. The exact was put there so that routes for viewing a specific article using its slug will be able to direct to the specific article page. If it is removed single articles would not be able to be viewed. Is there a workaround for this issue if exact is to be removed?
codeBlock-1984
force-pushed
the
ft-search-articles-by-tag-166840979
branch
from
87a1aeb
to
ab63406
Compare
codeBlock-1984
force-pushed
the
ft-search-articles-by-tag-166840979
branch
from
ab63406
to
f9bcd25
Compare
- Create actions for searching by tag - Create components for filtered articles page - Write unit tests [Delivers #166840979]
codeBlock-1984
force-pushed
the
ft-search-articles-by-tag-166840979
branch
from
f9bcd25
to
eab0405
Compare
|
Code Climate has analyzed commit eab0405 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (70% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.2% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions: