Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Forgejo #95

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Add support for Forgejo #95

merged 7 commits into from
Sep 9, 2024

Conversation

crop2000
Copy link
Contributor

No description provided.

@piegamesde
Copy link
Collaborator

piegamesde commented Jul 22, 2024

Thank you, that looks like a pretty good start already. How does forgejo differ from Gitea? Could we maybe even support both simply by adding an alias to the CLI subcommand?

Also, please add some tests, both a Rust test (I'd suggest using the Lix repo as test subject) and a mock test in test.nix

P.S.: Your commit is credited to @olafklingt instead of you, please double-check that this is indeed correct

@crop2000 crop2000 force-pushed the master branch 2 times, most recently from 494ae9c to 87ffeba Compare July 23, 2024 01:18
@crop2000
Copy link
Contributor Author

i did hand test it with lix, and can write some Rust test and a mock tests.
I don't know about the differences to gittea.
But as what we are using is fairly similar to github i don't expect that they diverged on this topic.

@crop2000
Copy link
Contributor Author

I tend to feel that adding gitea support via a alias is just cluttering the cli ux ... so i didn't add an alias.

Copy link
Collaborator

@piegamesde piegamesde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking mostly good to me, just some code nits

src/cli.rs Outdated Show resolved Hide resolved
src/git.rs Outdated Show resolved Hide resolved
src/git.rs Outdated Show resolved Hide resolved
test.nix Outdated Show resolved Hide resolved
@crop2000
Copy link
Contributor Author

crop2000 commented Sep 7, 2024

are you interested in this pr?

Copy link
Collaborator

@piegamesde piegamesde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, still interested. Just spread a bit thin at the moment unfortunately

src/git.rs Outdated Show resolved Hide resolved
@piegamesde piegamesde merged commit 36f49ba into andir:master Sep 9, 2024
1 check passed
@crop2000
Copy link
Contributor Author

crop2000 commented Sep 9, 2024

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants