-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Forgejo #95
Conversation
Thank you, that looks like a pretty good start already. How does forgejo differ from Gitea? Could we maybe even support both simply by adding an alias to the CLI subcommand? Also, please add some tests, both a Rust test (I'd suggest using the Lix repo as test subject) and a mock test in P.S.: Your commit is credited to @olafklingt instead of you, please double-check that this is indeed correct |
494ae9c
to
87ffeba
Compare
i did hand test it with lix, and can write some Rust test and a mock tests. |
I tend to feel that adding gitea support via a alias is just cluttering the cli ux ... so i didn't add an alias. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking mostly good to me, just some code nits
Co-authored-by: piegames <[email protected]>
are you interested in this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, still interested. Just spread a bit thin at the moment unfortunately
:) |
No description provided.