Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add MSVC 2019 x64 build #16

Merged
merged 2 commits into from
Oct 24, 2020
Merged

add MSVC 2019 x64 build #16

merged 2 commits into from
Oct 24, 2020

Conversation

Garcia6l20
Copy link

No description provided.

@andreasbuhr
Copy link
Owner

That's cool.

When I tried it, it failed because of the noop_coroutine, see https://github.com/andreasbuhr/cppcoro/runs/1294521699 .
Probably you already have a fix for that, could you open a pull request with a fix towards the branch "unify_experimental_includes" please? Lewis baker suggested in lewissbaker#171 to "Maybe put this inside #if CPPCORO_COMPILER_SUPPORTS_SYMMETRIC_TRANSFER and add an include of <cppcoro/config.hpp>?".

@Garcia6l20
Copy link
Author

Sure, there is also some workaround for MSVC 2017 that are not required anymore with 2019, shall I add those changes too ?

@andreasbuhr
Copy link
Owner

In his comments to other pull requests, Lewis Baker seemed to care about MSVC 2017, so I'd say yes, go ahead please. :-)

@andreasbuhr
Copy link
Owner

That's great, thanks a lot.

@andreasbuhr andreasbuhr merged commit 76fae81 into andreasbuhr:add_github_actions Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasbuhr andreasbuhr andreasbuhr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Garcia6l20 @andreasbuhr