small changes css and template to be more specific in selectors, add …

…sr-only text to eye icon
andreasschenkel · Jan 6, 2024 · 37652e1 · 37652e1
1 parent 1f699c5
commit 37652e1
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/lang/en/block_overviewmyrolesincourses.php b/lang/en/block_overviewmyrolesincourses.php
@@ -29,6 +29,8 @@
 $string['agendanothidden'] = 'Not hidden courses';
 $string['agendahidden'] = 'Hidden courses';
 $string['butnotvisible'] = 'but not visible';
+$string['courseisnothidden'] = 'Course is not hidden';
+$string['courseishidden'] = 'Course is hidden';
 $string['defaultfoldonstart'] = 'Default: Fold on start';
 $string['defaultfoldonstart_desc'] = 'By default courselists are fold';
 $string['defaultshowpast'] = 'Default: Show past';

diff --git a/styles.css b/styles.css
@@ -1,3 +1,8 @@
+.overviewmyrolesincourses {
+    box-shadow: 0 0 5px 0 #ddd;
+    margin-bottom: 10px;
+}
+
 .overviewmyrolesincourses-bg-manager {
     background-color: #aaa;
 }
@@ -54,20 +59,20 @@
     display: none;
 }
 
-.row.duration {
+.overviewmyrolesincourses .row.duration {
     margin-left: 0;
 }
-.row.duration .col-8 {
+.overviewmyrolesincourses .row.duration .col-8 {
     padding-left: 0;
 }
-.row.duration .col-4 {
+.overviewmyrolesincourses .row.duration .col-4 {
     padding-right: 10px;
 }
 
 .overviewmyrolesincourses-tools {
     text-align: right;
 }
 
-.summary .no-overflow p {
+.overviewmyrolesincourses .summary .no-overflow p {
     margin-bottom: 0.5rem;
 }
diff --git a/templates/overviewmyrolesincourses.mustache b/templates/overviewmyrolesincourses.mustache
@@ -74,7 +74,7 @@
     }
 }}
 
-<div class="border shadow mb-4">
+<div class="overviewmyrolesincourses">
     <script>
         function myFunction{{roleshortname}}() {
             var element = document.getElementById("overviewmyrolesincourses-visibility-{{roleshortname}}");
@@ -102,8 +102,12 @@
                         {{#favourite}}
                             ⭐
                         {{/favourite}}
-                        {{^dimmed}}<span><i class="fa fa-eye" aria-hidden="true"></i></span>{{/dimmed}}
-                        {{#dimmed}}<span><i class="fa fa-eye-slash" aria-hidden="true"></i></span>{{/dimmed}}
+                        {{^dimmed}}<span><i class="fa fa-eye" aria-hidden="true"></i></span>
+                            <span class="sr-only">{{# str }} courseisnothidden, block_overviewmyrolesincourses {{/str}}</span>
+                        {{/dimmed}}
+                        {{#dimmed}}<span><i class="fa fa-eye-slash" aria-hidden="true"></i></span>
+                            <span class="sr-only">{{# str }} courseishidden, block_overviewmyrolesincourses {{/str}}</span>
+                        {{/dimmed}}
                         {{#showdeleteicon}}
                             <a href="{{urldelete}}">
                                 <i class="fa fa-trash" aria-hidden="true"></i>