-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Admin::DomainAllow methods #413
Add Admin::DomainAllow methods #413
Conversation
# Conflicts: # bigbone/src/main/kotlin/social/bigbone/MastodonClient.kt
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #413 +/- ##
============================================
+ Coverage 49.84% 49.86% +0.02%
- Complexity 661 668 +7
============================================
Files 162 165 +3
Lines 4484 4528 +44
Branches 284 284
============================================
+ Hits 2235 2258 +23
- Misses 1996 2016 +20
- Partials 253 254 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking mostly good! Thanks for your contribution 🙌
bigbone/src/main/kotlin/social/bigbone/api/method/admin/AdminDomainAllowMethods.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! 😊 🚀
Description
This PR implements the domain allows API so that users with role of admin to both see allowed federated domains, remove allowed domain and add new domain to be federated.
This closes #328
Type of Change
How Has This Been Tested?
Gradle ktlint, gradle check, gradle detect and gradle build
Mandatory Checklist
gradle check
and there were no errors reportedOptional checks
I implemented related RX counter part and implemented unit test.
I also updated the API coverage page with corresponding ones developed in this PR.