Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Admin::DomainAllow methods #413

Merged
merged 6 commits into from
Dec 30, 2023

Conversation

G10xy
Copy link
Contributor

@G10xy G10xy commented Dec 29, 2023

Description

This PR implements the domain allows API so that users with role of admin to both see allowed federated domains, remove allowed domain and add new domain to be federated.

This closes #328

Type of Change

  • New feature

How Has This Been Tested?

Gradle ktlint, gradle check, gradle detect and gradle build

Mandatory Checklist

  • I ran gradle check and there were no errors reported
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • I have added KDoc documentation to all public methods

Optional checks

I implemented related RX counter part and implemented unit test.
I also updated the API coverage page with corresponding ones developed in this PR.

@PattaFeuFeu PattaFeuFeu added the enhancement New feature or request label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (90c8259) 49.84% compared to head (107a6c6) 49.86%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #413      +/-   ##
============================================
+ Coverage     49.84%   49.86%   +0.02%     
- Complexity      661      668       +7     
============================================
  Files           162      165       +3     
  Lines          4484     4528      +44     
  Branches        284      284              
============================================
+ Hits           2235     2258      +23     
- Misses         1996     2016      +20     
- Partials        253      254       +1     
Files Coverage Δ
...e/src/main/kotlin/social/bigbone/MastodonClient.kt 35.45% <100.00%> (+0.16%) ⬆️
...igbone/api/method/admin/AdminDomainBlockMethods.kt 60.78% <100.00%> (ø)
...igbone/api/method/admin/AdminDomainAllowMethods.kt 95.00% <95.00%> (ø)
...ocial/bigbone/api/entity/admin/AdminDomainAllow.kt 33.33% <33.33%> (ø)
...cial/bigbone/rx/admin/RxAdminDomainAllowMethods.kt 0.00% <0.00%> (ø)

Copy link
Collaborator

@PattaFeuFeu PattaFeuFeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking mostly good! Thanks for your contribution 🙌

Copy link
Collaborator

@PattaFeuFeu PattaFeuFeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! 😊 🚀

@PattaFeuFeu PattaFeuFeu changed the title Feature/domain allow methods Add Admin::DomainAllow methods Dec 30, 2023
@PattaFeuFeu PattaFeuFeu merged commit 887d8f6 into andregasser:master Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Admin Domain Allows API
2 participants