Update ShopBuyEvent.java and CategoryContent.java #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed tag apply for 1.18.2, 1.17.1, 1.12.2 and 1.8.8 where the tag wouldnt get applied ever (because the NBTTag was getting applied only if the item was null with no additive tags)
Tag wouldnt get applied either in this part
Updated ShopBuyEvent.java and CategoryContent.java to allow getting the slot that was clicked for the purchase and slight readibility improvements
andrei1058
requested changes
Feb 10, 2025
| } else { | ||
| ct = contentTiers.get(shopCache.getContentTier(getIdentifier())); | ||
| } | ||
| if (!shopCache.hasCachedItem(this)) ct = contentTiers.get(0); |
There was a problem hiding this comment.
we boomers. we do not like this code style without brackets
| @@ -46,17 +47,35 @@ public ShopBuyEvent(Player buyer, ICategoryContent categoryContent) { | |||
| this.categoryContent = categoryContent; | |||
| this.buyer = buyer; | |||
| this.arena = null; | |||
| this.slot = -1; | |||
There was a problem hiding this comment.
use a Integer object so we can return null when no slot is clicked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ShopBuyEvent.java and CategoryContent.java to allow getting the slot that was clicked for the purchase and slight readibility improvements