Use correct HTTP method for new page endpoint #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aus70
added a commit
to aus70/chrome-remote-interface
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an incompatibility with recent chromium versions (111+)
Details
The main culprit is the API for creating pages =
PUT /json/new. This library uses wrong HTTP methodGEThere. This got unnoticed up until now because chromium did not enforce the correct method. However, this changed recently where chromium started enforcing it and responding with an error:For context, this has been introduced by this chromium PR: https://chromium-review.googlesource.com/c/chromium/src/+/4110715