Add webkit webview sample #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebView/WebkitWebView/app/src/main/java/com/google/webkit/webviewsample/MainActivity.kt
Outdated
Show resolved
Hide resolved
WebView/WebkitWebView/app/src/main/java/com/google/webkit/webviewsample/MainActivity.kt
Outdated
Show resolved
Hide resolved
WebView/WebkitWebView/app/src/main/java/com/google/webkit/webviewsample/WebViewClientImpl.kt
Show resolved
Hide resolved
niharika2810
reviewed
Mar 3, 2025
| @@ -0,0 +1,31 @@ | |||
| /* | |||
| * Copyright 2024 The Android Open Source Project | |||
There was a problem hiding this comment.
This should have taken the year 2025. Could you please check and run spotless again? Spotless should be able to take the latest year only.
| compose-material = { group = "androidx.compose.material", name = "material" } | ||
|
|
||
| # Testing | ||
| junit = { group = "junit", name = "junit", version.ref = "jUnit"} |
There was a problem hiding this comment.
Are we doing any testing? If not, can we check and remove the dependencies not being used?
| @@ -0,0 +1,20 @@ | |||
| # | |||
| # Copyright 2023 Google LLC | |||
| @@ -0,0 +1,15 @@ | |||
| /* | |||
| * Copyright 2024 The Android Open Source Project | |||
There was a problem hiding this comment.
Can you check here on how to add this? Year should be variable and take current year only. https://github.com/android/identity-samples/tree/main/CredentialProvider/MyVault/spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.