Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1079: Update thumb movement range by thumb size, in app scrollbars #1080

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

oikvpqya
Copy link
Contributor

@oikvpqya oikvpqya commented Dec 6, 2023

What I have done and why
Update thumb movement range by thumb size, in app scrollbars

Fixes #1079

Do tests pass?

  • [✓] Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • [✓] Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Is this your first pull request?

Change-Id: I4438debd5037965a837758e0c78b110ab8197da5
@oikvpqya
Copy link
Contributor Author

oikvpqya commented Dec 7, 2023

Add video. (Left : Before, Right : After)
With this PR, the thumb position is now correct.

output.mp4

Change-Id: I7ef067a950b4b5911b8c2e6a8c1f72c3e95d938d
Copy link
Contributor

@tunjid tunjid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tunjid tunjid merged commit 63bba2e into android:main Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Scrollbar thumb position might be incorrect, because of a lot of content in LazyList
2 participants