Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the previous code , currentTopLevelDestination would be momentaril… #1685

Closed

Conversation

mahmed1987
Copy link

Issue
currentTopLevelDestination is null momentarily , causing the TopAppBar to flicker while navigating the top level destinations.
In short the problem lies here

val currentTopLevelDestination: TopLevelDestination?
        @Composable get() {
            return TopLevelDestination.entries.firstOrNull { topLevelDestination ->
                Log.d("currentDestination","$currentDestination")
                currentDestination?.hasRoute(route = topLevelDestination.route) ?: false
            }
        }

The log statement above would confirm that while switching between the top level composables , the currentDestination is obtained as null at times , until it is not .

I dont have the exact reasoning as to why that is. My hypothesis is that since there is no "gate" between the currentDestination composable and the currentTopLevelDestination , currentTopLevelDestination reacts to everything that occurs to currentDestination and perhaps currentDestination goes through a null while going from one destination to another.

Solution

I just gated the currentTopLevelDestination with a remember .

Before
After

Copy link

google-cla bot commented Nov 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mahmed1987 mahmed1987 closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant