Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing reference in Typography sample #207

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Fixing reference in Typography sample #207

merged 5 commits into from
Feb 8, 2024

Conversation

arriolac
Copy link
Contributor

@arriolac arriolac commented Feb 6, 2024

Same PR as #198 but from a branch in the repo.

Opening this as a branch on our repo as PRs from works are currently failing. See #208

Changes:

  • Fixed references in Typography sample.
  • Update TextDownloadableFontsSnippets.kt

jwill and others added 5 commits January 30, 2024 18:04
body1/body2/h4 don't exist in M3 Typography. The options are {display|headline|title|body|label}{Small|Medium|Large}.
Typography should use m3 import.
@arriolac arriolac marked this pull request as ready for review February 6, 2024 21:43
@arriolac arriolac requested review from a team and IanGClifton February 8, 2024 16:23
@arriolac arriolac merged commit 9c71245 into main Feb 8, 2024
5 checks passed
@arriolac arriolac deleted the m3-typography branch February 8, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants