Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heavily refactor everything #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leontrolski
Copy link

@leontrolski leontrolski commented Feb 12, 2021

I'm not suggesting you merge this, just though you might find it interesting :-)

I really liked the core of your code, but thought I'd have a go at translating into my style, I'm probably going to use a modified version in a personal project if that's all cool?

Thanks for the great work!

@andychu
Copy link
Owner

andychu commented Feb 12, 2021

This looks nice! The static types are a nice addition. I suggest just publishing it and then I can link to it for people who would like a different style.

Actually it relates precisely to my point here: http://www.oilshell.org/blog/2016/11/05.html

So I can link to your fork there. I don't think I will modify this code again so it makes sense to have two separate copies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants