Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed add dll plugins #32

Closed

Conversation

davidnguyen11
Copy link
Contributor

I added setDllPlugin in webpack packages. If it is ok, I will update document

@eXon
Copy link
Contributor

eXon commented Dec 10, 2016

It's great to have DLLs but it's better when you can reference them ;)

You probably should add a core block for DllReferencePlugin. Looking forward to using it 👍

@andywer
Copy link
Owner

andywer commented Dec 10, 2016

Hey guys! Interesting to see that the DLL functionality is such a hot feature.

But the proposed setDllPlugin function doesn't make it any easier to use it, I think. Is setDllPlugin(x) so much more readable than addPlugins([ new webpack.DllPlugin(x) ])?

(Feel free to share your opinion anytime if you feel differently about this! 😉)

Using the test app to demonstrate how the DllPlugin can be used seems like a good idea on first glance, but it also makes it more complicated. There is another webpack config file, another script in the package.json and so it doesn't feel as light-weight anymore.

I would suggest we provide a separate test app for the DLL functionality.

@andywer
Copy link
Owner

andywer commented Dec 10, 2016

Or even better: I don't know if you got time for this, but it might be really cool to write a short blog post / tutorial (maybe on medium.com) about why and how to use the DllPlugin and provide an easy to use and easy to understand configuration like this one here.

It might even live in a separate examples repository and we just link there.

Or maybe we can somehow make it simpler to use the DLL feature...

@andywer
Copy link
Owner

andywer commented Dec 10, 2016

Just recognized this is the follow-up of #16.

And I proposed exactly this, now I am not satisfied. Sorry man! 🙈😅

I guess I expected the util function to simplify the DllPlugin's options some more...

Sorry for the inconvenience! I appreciate your efforts.

@andywer
Copy link
Owner

andywer commented Jan 25, 2017

Hey @nndung179!
Anything new here or can I close the PR for now?

@davidnguyen11
Copy link
Contributor Author

I think PR should br closed. I will get back another time

@andywer
Copy link
Owner

andywer commented Jan 25, 2017

Ok 👍

And thx for the quick reply :)

@andywer andywer closed this Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants