Fixes an error when mutating a pod. K8s was logging an error about an…

… internal error because the kind was / instead of AdmissionReview (kubeflow#1421) Changed where we set Response
aneagoe · Dec 3, 2021 · 2919f52 · 2919f52
1 parent ba16242
commit 2919f52
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pkg/webhook/webhook.go b/pkg/webhook/webhook.go
@@ -298,9 +298,12 @@ func (wh *WebHook) serve(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	response := admissionv1.AdmissionReview{}
+	response := admissionv1.AdmissionReview{
+		TypeMeta: metav1.TypeMeta{APIVersion: "admission.k8s.io/v1", Kind: "AdmissionReview"},
+		Response: reviewResponse,
+	}
+
 	if reviewResponse != nil {
-		response.Response = reviewResponse
 		if review.Request != nil {
 			response.Response.UID = review.Request.UID
 		}