Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/chips): Async chips with a delay are not highlighted #27399

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

yurakhomitsky
Copy link
Contributor

Fixes a bug in the Angular Material chips component where async chips with a delay were not highlighted correctly.

Fixes #27370

@google-cla
Copy link

google-cla bot commented Jul 2, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@yurakhomitsky yurakhomitsky force-pushed the fix-selecting-async-chip branch from e0772e2 to f69992f Compare July 2, 2023 11:25
@yurakhomitsky yurakhomitsky marked this pull request as draft July 2, 2023 11:29
@yurakhomitsky yurakhomitsky marked this pull request as ready for review July 2, 2023 13:44
@yurakhomitsky yurakhomitsky force-pushed the fix-selecting-async-chip branch from f69992f to 9ace971 Compare July 2, 2023 14:04
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker area: material/chips labels Jul 11, 2023
@yurakhomitsky yurakhomitsky force-pushed the fix-selecting-async-chip branch 2 times, most recently from bd5b54c to 3ecfb2b Compare September 27, 2023 10:36
@mmalerba mmalerba self-assigned this Sep 28, 2023
@yurakhomitsky yurakhomitsky force-pushed the fix-selecting-async-chip branch from 3ecfb2b to 7af22cb Compare November 6, 2023 09:36
Fixes a bug in the Angular Material `chips` component where async chips with a delay were not highlighted correctly.

Fixes angular#27370
@yurakhomitsky yurakhomitsky force-pushed the fix-selecting-async-chip branch from 7af22cb to f50bae8 Compare February 15, 2024 10:28
@josephperrott josephperrott requested a review from a team as a code owner December 18, 2024 17:40
@josephperrott josephperrott requested review from amysorto and andrewseguin and removed request for a team December 18, 2024 17:40
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Feb 3, 2025
@mmalerba mmalerba merged commit 4eb06ac into angular:main Feb 3, 2025
12 of 14 checks passed
@mmalerba
Copy link
Contributor

mmalerba commented Feb 3, 2025

The changes were merged into the following branches: main, 19.1.x

mmalerba pushed a commit that referenced this pull request Feb 3, 2025
…7399)

Fixes a bug in the Angular Material `chips` component where async chips with a delay were not highlighted correctly.

Fixes #27370

(cherry picked from commit 4eb06ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/chips target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(CHIPS): Async Chips are not highlighted with Forms
2 participants