Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/icon): Change icon font default to Material symbols from Material icons #30037

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(material/icon): Change icon font default to Material symbols from Material icons #30037

wants to merge 3 commits into from

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented Nov 18, 2024 •
edited
Loading

Fixes #24845

@amysorto amysorto force-pushed the google-symbols branch 2 times, most recently from a0cde04 to 7091e5c Compare November 20, 2024 19:04
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Nov 20, 2024
@amysorto amysorto changed the title Change icon font default to Material symbols from Material icons feat(material/icon): Change icon font default to Material symbols from Material icons Nov 20, 2024
@amysorto amysorto marked this pull request as ready for review November 20, 2024 19:58
@amysorto amysorto requested a review from a team as a code owner November 20, 2024 19:58
@amysorto amysorto requested review from crisbeto and andrewseguin and removed request for a team November 20, 2024 19:58
@amysorto amysorto added target: minor This PR is targeted for the next minor release action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Nov 20, 2024
@angular-robot angular-robot bot added area: build & ci Related the build and CI infrastructure of the project area: material/icon labels Dec 13, 2024
@amysorto amysorto added merge: preserve commits When the PR is merged, a rebase and merge should be performed and removed area: material/icon area: build & ci Related the build and CI infrastructure of the project labels Dec 13, 2024
mauxnier
mauxnier reviewed Jan 10, 2025
View reviewed changes
src/material/schematics/ng-update/index.ts
}

const materialSymbolsFont =
'https://fonts.googleapis.com/icon?family=Material+Symbols+Outlined';
Copy link

@mauxnier mauxnier Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it work for offline projects that use angular?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauxnier mauxnier mauxnier left review comments

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner automatically assigned from angular/components-googlers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner automatically assigned from angular/components-googlers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer detected: feature PR contains a feature commit merge: preserve commits When the PR is merged, a rebase and merge should be performed target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(material icon): Support for Material Symbols
2 participants
@amysorto @mauxnier