fix(material/stepper): fix nested tabpanel role in stepper #30410
+49
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
the
dev-app preview
|
Deployed dev-app for c71e31b to: https://ng-dev-previews-comp--pr-angular-components-30410-dev-h02yz5i9.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
force-pushed
the
stepper-aria-roles-fix
branch
from
b1e74eb to
49c1419
Compare
essjay05
requested review from
mmalerba and
andrewseguin
and removed request for
a team
Updates Angular Components Stepper component to fix the nested aria-role tabpanel in the vertical stepper. Fixes b/361783174
…ee-related Updates Angular Components Stepper vertical stepper to use and match correct aria attributes to match role=tree instead of using tablist/tab/tabpanel since moving the tabpanel content outside of the mat-step changes the visual look of the vertical stepper. WIP: update the docs to mention change of roles for vertical stepper to tree and its appropriate aria-attributes. Fixes b/361783174
Updates previous fix to Angular Components stepper to remove unnecessary roles and attributes. Also updates Stepper docs with latest vertical stepper aria attribute and role changes. Updates stepper-demo heading level elements for accessibility purposes.
Cleans up previous changes by removing unnecessary aria role of group wrapping the step-header and step-content.
essjay05
force-pushed
the
stepper-aria-roles-fix
branch
from
3632365 to
c71e31b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular Components Stepper component to fix the nested aria-role "tabpanel" in the vertical stepper by converting vertical stepper role from "tablist" to "tree" and updating its associated aria attributes.
Before fix screenshot
After fix screenshot
Fixes b/361783174