Fixes FancyHolograms HologramDriver implementation

anjoismysign · Aug 2, 2024 · 8f41070 · 8f41070
1 parent 04966ef
commit 8f41070
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/main/java/us/mytheria/bloblib/hologram/FancyHolograms.java b/src/main/java/us/mytheria/bloblib/hologram/FancyHolograms.java
@@ -14,6 +14,7 @@
 import org.joml.Vector3f;
 
 import java.util.List;
+import java.util.Objects;
 
 public class FancyHolograms implements HologramDriver {
 
@@ -33,7 +34,7 @@ public void create(String name,
                 saveToConfig,
                 false,
                 Color.fromARGB(0, 0, 0, 0),
-                null,
+                Display.Billboard.VERTICAL,
                 null,
                 false,
                 -1,
@@ -85,7 +86,8 @@ public void create(String name,
     }
 
     @Nullable
-    public Hologram get(String name) {
+    public Hologram get(@NotNull String name) {
+        Objects.requireNonNull(name, "'name' cannot be null");
         HologramManager manager = FancyHologramsPlugin.get().getHologramManager();
         return manager.getHologram(name).orElse(null);
     }
@@ -103,7 +105,7 @@ public void remove(String name) {
         Hologram hologram = get(name);
         if (hologram == null)
             return;
-        hologram.deleteHologram();
+        FancyHologramsPlugin.get().getHologramManager().removeHologram(hologram);
     }
 
     @Override