Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For PostgreSQL 14+, provide DROP INDEX migration lines that use CONCURRENTLY #437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

For PostgreSQL 14+, provide DROP INDEX migration lines that use CONCURRENTLY #437

wants to merge 1 commit into from

Commits on Jan 3, 2024

  1. Simplify the presentation 

    Present a explanation box recommending to use CONCURRENTLY with DROP
INDEX. In Active Record, this requires two things:
disable_ddl_transaction! once at the top of the migration file, and
"algorithm: :concurrently" option added to every remove_index line

Since this is a sensible default when PostgreSQL 14 or greater is in
use, since it can avoid downtime from an index drop, make it the
default.
Remove the ability to disable it since it seems unnecessary in
retrospect.

Only show the explanation box and only add the option to
remove_index when version 14 or greater is in use
    @andyatkinson
    andyatkinson committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    a36f400 View commit details
    Browse the repository at this point in the history