-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
improvement(deck-picker): use back callbacks
This uses a class and a handler to detect changes to the preference rather than checking inside onBackPressed Issue 14558
- Loading branch information
1 parent
8dfff03
commit 1f9557c
Showing
4 changed files
with
122 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
AnkiDroid/src/main/java/com/ichi2/anki/android/back/ExitViaDoubleTapBackBackPressCallback.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * Copyright (c) 2025 David Allison <[email protected]> | ||
| * | ||
| * This program is free software; you can redistribute it and/or modify it under | ||
| * the terms of the GNU General Public License as published by the Free Software | ||
| * Foundation; either version 3 of the License, or (at your option) any later | ||
| * version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, but WITHOUT ANY | ||
| * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A | ||
| * PARTICULAR PURPOSE. See the GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License along with | ||
| * this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| package com.ichi2.anki.android.back | ||
|
|
||
| import android.content.SharedPreferences.OnSharedPreferenceChangeListener | ||
| import androidx.activity.OnBackPressedCallback | ||
| import androidx.annotation.StringRes | ||
| import androidx.preference.PreferenceManager | ||
| import com.google.android.material.snackbar.Snackbar | ||
| import com.ichi2.anki.AnkiActivity | ||
| import com.ichi2.anki.AnkiDroidApp | ||
| import com.ichi2.anki.R | ||
| import com.ichi2.anki.settings.Prefs | ||
| import com.ichi2.anki.snackbar.showSnackbar | ||
| import com.ichi2.libanki.Consts | ||
| import com.ichi2.utils.HandlerUtils | ||
| import timber.log.Timber | ||
|
|
||
| /** | ||
| * Note: this uses sharedPreferences via AnkiDroidApp, so must be called after | ||
| * [AnkiActivity.showedActivityFailedScreen] | ||
| * | ||
| * @see Prefs.exitViaDoubleTapBack | ||
| */ | ||
| // TODO: Convert this to a class when context parameters are usable | ||
| fun AnkiActivity.exitViaDoubleTapBackCallback( | ||
| @StringRes stringRes: Int, | ||
| ): OnBackPressedCallback = | ||
| object : OnBackPressedCallback(enabled = Prefs.exitViaDoubleTapBack) { | ||
| lateinit var strongListenerReference: OnSharedPreferenceChangeListener | ||
|
|
||
| override fun handleOnBackPressed() { | ||
| showSnackbar(stringRes, Snackbar.LENGTH_SHORT) | ||
| this.isEnabled = false | ||
| HandlerUtils.executeFunctionWithDelay(Consts.SHORT_TOAST_DURATION) { | ||
| this.isEnabled = true | ||
| } | ||
| } | ||
| }.also { callback -> | ||
| // PreferenceManager uses weak references, so we need our own strong reference which | ||
| // will go out of scope | ||
| callback.strongListenerReference = | ||
| OnSharedPreferenceChangeListener { prefs, key -> | ||
| if (key == getString(R.string.exit_via_double_tap_back_key)) { | ||
| callback.isEnabled = | ||
| Prefs.exitViaDoubleTapBack.also { | ||
| Timber.i("exit via double tap callback -> %b", it) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| PreferenceManager | ||
| .getDefaultSharedPreferences(AnkiDroidApp.instance) | ||
| .registerOnSharedPreferenceChangeListener(callback.strongListenerReference) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters