-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multiselect delete in manageNotesType #17091
base: main
Are you sure you want to change the base?
Conversation
I think the current delete option shouldn't be there. It's weird that we have the same functionality twice. Also, it makes me anxious when the delete option (a high-risk option) is very easy to reach. Perhaps, long-press then delete can become the default, maintainers? |
you got a point. We can disable the delete option while in multiSelect mode or we can completely remove the default delete button and there is one more problem. When we long press and multiselct mode enables, the other functionalities like add ,rename ,edit are still accessible. so should we disable them too ? |
I'd say yes, remove all but you may want to wait for the maintainers' opinions. |
Yes, we should disable at least rename, edit, delete When the user is in multiselect mode and presses the back button, instead of navigating back to the previous screen (DeckPicker screen), the multiselect mode should be exited. The back button press should act as a trigger to clear the current selection and exit the multiselect state, keeping the user on the same screen |
AnkiDroid/src/main/java/com/ichi2/anki/notetype/NoteTypeAdapterCallbacks.kt
Outdated
Show resolved
Hide resolved
That's not the case. To reproduce, have more than 5-10 note types, enable multiselect mode and scroll down
should fix |
ok , I'll check and correct it |
546949f
to
7733107
Compare
02a51ad
to
c4f8190
Compare
This comment was marked as resolved.
This comment was marked as resolved.
e592419
to
3c56315
Compare
In addition, please rebase/squash and force push, rather than adding merge commits to the history |
33ba166
to
56ce5b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very brief review
AnkiDroid/src/main/java/com/ichi2/anki/notetype/ManageNotetypes.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/notetype/ManageNotetypes.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/notetype/ManageNotetypes.kt
Outdated
Show resolved
Hide resolved
i'll fix that |
56ce5b1
to
8f9cb1f
Compare
Added Multiselect delete in manageNoteType
Purpose / Description
Describe the problem or feature and motivation
Fixes
Checklist
Please, go through these checks before submitting the PR.
Screencast.from.2024-09-19.12-33-39.webm
After Changes
Screencast.from.2024-09-22.23-08-54.webm