-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Enable multi-line support for the deck picker footer #17349
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. I appreciate the improvement.
I'll admit that, having the text below the + symbol is not ideal. It's still readable, and I don't expect that this bug is worth doing more effort to find a better design to solve it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of similar to what was proposed in #16965, so the comments about the screen edges made by @lukstbit
still stands.
Also, the screenshot in the PR description evidently shows that the text can be hidden by the Add
button
As @Arthur-Milchior mentioned, this bug isn’t worth further effort and can be addressed in #17334, which completes the migration to edge-to-edge. |
@Aditya13s I don't have more authority than @BrayanDSO. I have approved this, but we usually wants to reviewer, and so if the other reivewer does not appreciate, this is up to discussion. @BrayanDSO Can I ask what would be your preferred solution regarding the button?
Yeah, but in this case, there is not even a point of landing your change if we suspect we may need to change the result soon after. We should try to fix #14641 simultaneously, given that it consider the same part of the UI. To be clear, I still believe that your change is an improvement compared to the current state. After all, the total quantity of missing text is quite smaller. But I prefer to have a single merged change that deals with all the issues related to this text view simultaneously |
53340f2
to
7968085
Compare
Yes. I believe that it can be easily done by editing only the layout files. There shouldn't be a need to do it programmatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this bug isn’t worth further effort and can be addressed in #17334, which completes the migration to edge-to-edge.
Edge to edge becoming the default affects the interaction between the info text and the screen borders. The bug in the picture isn't related to edge to edge, it's related to the changes you've made in this PR and the interaction between the info text and the fab. So the current "fix" only fixes the issue partially and would result in a new bug report in the near future.
There should be enough space made available for the info text between the screen margin and fab button. It shouldn't be visible below or above the fab button. |
7968085
to
0f1454d
Compare
Clearly this result looks nicer. I admit I regret that it moves the FAB even when the text is small. I'd have preferred if we had a way to ensure it remains at the same place if possible. I admit I really don't know XML layout enough to know how to do that. |
0f1454d
to
9aed7c9
Compare
Fixed it by dynamically adjusting the layout's bottom margin. If the line count is greater than 1, the margin changes; if it's 1, no change occurs. |
9aed7c9
to
1452476
Compare
@BrayanDSO Please review the changes |
1452476
to
c209a62
Compare
c209a62
to
c895a76
Compare
@lukstbit Merge Conflicts Resolved. Please review this. |
Purpose / Description
The purpose of this change is to allow the footer of the deck picker to display multiple lines of text.
Fixes
Approach
The
setSingleLine
method has been removed from theDeckPicker.kt
file to allow the footer text to display across multiple lines. Additionally, a.replace
function was implemented to ensure that newline characters in the text fromsched.studiedToday()
are replaced with spaces, preventing any text from being hidden.How Has This Been Tested?
This change has been tested using different font sizes and languages.
Screenshot
Checklist