Resolves #17543 TTS availability among devices #17561
Conversation
…prove performance" in MediaTest.kt file in Line 131.
* "The argument can be converted to 'Set' to improve performance"
|
Important Maintainers: This PR contains Strings changes
|
|
Hey, this has commits from your previous PR which makes it harder to see what are the real changes. You should git rebase on top of main to only see here the commit with the actual changes. |
|
probably best to work off branches as well - I see you are using your main branch instead of feature development forks in your repo, that will contribute to this sort of messy commit history. Better to keep your main in sync with upstream main, and always branch fresh for a new feature With regards to language, don't worry about this: only the main |
|
Thank you for pointing it out. Now it looks fine. |
| // check whether tts is available or not first | ||
| val ttsAvailable = checkTtsEngine() | ||
| if (!ttsAvailable) { | ||
| AlertDialog.Builder(requireContext()).show { | ||
| setTitle(R.string.tts_unavailable_title) | ||
| setMessage(R.string.tts_unavailable_message) | ||
| setIcon(R.drawable.ic_warning) | ||
| setPositiveButton(R.string.dialog_ok) { _, _ -> } | ||
| } | ||
| ttsPref.isChecked = false | ||
| return@setOnPreferenceChangeListener false | ||
| } |
There was a problem hiding this comment.
This feature is intended to be deleted.
We need to handle the unified mechanism of TTS:
https://docs.ankiweb.net/templates/fields.html#text-to-speech-for-individual-fields
david-allison
added
the
Needs Author Reply
|
Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
Resolves #17543 Added Text-to-Speech engine availability check, accounting for devices like Amazon Fire Stick.
Well, here I might need some help implementing all string values for "tts_unavailable_title" and "tts_unavailable_message." :)