Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing notetype to Cloze if From InstantEditor #17638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soCallmeAdityaKumar
Copy link
Contributor

@soCallmeAdityaKumar soCallmeAdityaKumar commented Dec 20, 2024

Purpose / Description

whenever user creates an instant card from instant editor it is of cloze type , but when NoteEditor is opened noteType should be cloze type

Fixes

How Has This Been Tested?

WhatsApp.Video.2024-12-20.at.8.25.57.PM.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY
Copy link
Contributor

I would expect it to be set to close and then again reset to the present note type

@criticalAY criticalAY self-requested a review December 22, 2024 19:50
@soCallmeAdityaKumar
Copy link
Contributor Author

I would expect it to be set to close and then again reset to the present note type

Sorry may be I didn't get you
You are saying that I need to change this in setNote so that it's changed into close type , rather than creating present type and than changing into cloze type ?

@criticalAY
Copy link
Contributor

I am asking what happens when the user is having basic note type in AnkiDroid and later open it via instant editor, here does the note type change back to basic once they are done saving the note?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants