Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): add emoji to pinned items to reorder #17642

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Dec 20, 2024

This orders all of the 'checks' together and makes 'Sync Translations' easier to recognize

Before:

  • Code Quality Checks
  • Emulator Tests
  • Publish
  • Sync Translations
  • Unit Tests

After:

  • 🚀 Publish
  • 🌐 Sync Translations
  • 🛠️ Code Quality Checks
  • 🛠️ Emulator Tests
  • 🛠️ Unit Tests

How Has This Been Tested?

Screenshot 2024-12-20 at 19 44 25 Screenshot 2024-12-20 at 19 45 58

https://github.com/david-allison/Anki-Android/actions

@david-allison
Copy link
Member Author

This may require a change of 'required checks' in the repo settings.

If this is a controversial change, close it, I'm not tied to it

We may also want Add/Remove Labels and Conflict Scan to have the 🛠️ so the PR checks are vertically aligned.

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 🆒

@mikehardy mikehardy enabled auto-merge December 20, 2024 19:52
@mikehardy
Copy link
Member

likely yes on required checks change, have to merge first to have the new names available for selection here https://github.com/ankidroid/Anki-Android/settings/branch_protection_rules/17281133

@david-allison
Copy link
Member Author

I'll add 🛠️ to:

  • Add/Remove Labels
  • Conflict Scan

This orders all of the 'checks' together
and makes 'Sync Translations' easier to recognize

Before:

* Code Quality Checks
* Emulator Tests
* Publish
* Sync Translations
* Unit Tests

After:

* 🚀 Publish
* 🌐 Sync Translations
* 🛠️ Code Quality Checks
* 🛠️ Emulator Tests
* 🛠️ Unit Tests

----

Conflict scan & Labels sometimes appear on the PRs checks,
so icons were added for consistency
@david-allison david-allison added this pull request to the merge queue Dec 20, 2024
Merged via the queue into ankidroid:main with commit 920e4cb Dec 20, 2024
9 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants