Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a skip button for all files access permission #17653

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skyblue7070
Copy link

Purpose / Description

Add a skip button to the require all files access permission screen.

Fixes

N/A

Approach

On the require all files access permission screen, add a skip button so user can proceed as if it were a play build.
Screen_recording_20241222_232511.webm
VideoCapture_20241223-214019-1

How Has This Been Tested?

SDK 35 emulator, SDK 33 physical device, and SDK 24 emulator

Learning (optional, can help others)

N/A

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

On the require all files access permission screen, add a skip button so user can proceed as if it were a play build.
Copy link

welcome bot commented Dec 23, 2024

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@skyblue7070
Copy link
Author

I will try to correct the error in a few days.

@BrayanDSO
Copy link
Member

Being able to continue without giving the permission is enough. Although most of the issue relates to work without the permission

@BrayanDSO BrayanDSO marked this pull request as draft December 23, 2024 16:34
@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Author Reply Waiting for a reply from the original author New contributor Strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants