feat: WidgetSmall redesign with material you dynamic color #17654
Conversation
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
There was a problem hiding this comment.
Interesting - looks like most of the work is in the icon specification?
Is there some way to preserve the visible difference between dev build and prod build like we have now with the red icon color vs the blue icon color?
Obviously the point of the change is to have the colors match theming - perhaps there is a way to badge the icon by layering a dev "sash" over it, similar to the badging plugin used by fastlane (underlying implementation here: https://github.com/HazAT/badge - perhaps it could be run during debug builds as a gradle step? Perhaps the generated badge could be in the debug src/res tree ? I'm not sure what is best)
| <solid android:color="@android:color/system_accent1_600" /> | ||
| </shape> | ||
|
|
||
| <!--<padding android:left="7dp"--> |
There was a problem hiding this comment.
Curious why there are commented out implementation lines in a new file?
Historically we don't keep commented out code in the codebase ever, that's what git history is for, and we definitely don't add new files with commented out implementation lines
| import com.ichi2.anki.AnkiDroidApp | ||
|
|
||
| class EmptyApplication : Application() { | ||
| override fun onCreate() { | ||
| super.onCreate() | ||
|
|
||
| DynamicColors.applyToActivitiesIfAvailable(this) |
There was a problem hiding this comment.
What value does this provide in the testutils EmptyApplication class ? (it may just need a comment but I'm curious if it does anything at all really? Does it make these things testable somehow?)
lukstbit
added
the
Needs Author Reply
|
@mikehardy just to note: the red isn't a beta feature, it's an indicator of "you have pending reviews". |
Ah interesting - that means that for the widgets at least there is currently no way to differentiate between "widgets built for the That whole sentence reads like an assertion but the question mark is key - I'm not sure |
|
I don't believe there is a difference for the widgets between beta and stable. I am concerned that we lose the distinction between 'done' and 'not done' with this PR. Some users love it: 
https://www.reddit.com/r/Anki/comments/1h81z48/comment/m0rcsuq/?context=1 |
Purpose / Description
The current small widget doesn't fit the style of the application or current versions of android material you theme
Fixes
Approach
Redesigned the widget and uses material you colors to fit
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)
Virtual pixel 3 on SDK 28 and pixel 7 on SDK 35
Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.
Screenshots
Improvements
Any feedback on the designs of the notification bubbles would be greatly appreciated :)