Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing language column header fixed(with viewmodel test) #17687

Closed

Conversation

soCallmeAdityaKumar
Copy link
Contributor

Purpose / Description

On Changing the language, heading doesn't changes immediately

Fixes

Approach

WhatsApp.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@soCallmeAdityaKumar
Copy link
Contributor Author

previous track ->#17497

@david-allison
Copy link
Member

david-allison commented Dec 29, 2024

@soCallmeAdityaKumar Could you close this PR and force push to the previous one (even if you're using git reset), so we don't lose review history

WARNING: This will wipe uncommitted changes

git checkout languageUp
git reset --hard aaa4823f37dd1a0a18ed7d579988931d20966a05
git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Browser Column Headers Language Doesn't Change
2 participants