Allow reopening the add cards window #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since changing notetype potentially changes deck
|
I think it makes sense to respect the preference here 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3702 as an alternative to #3755
With this change, reopening the add cards window behaves the same* as if the window was manually closed and reopened, i.e selecting both the default deck and notetype for adding
*The contents of some filled-in fields can be lost when switching to a notetype with fewer fields
For context on why keeping the same behaviour across opening and reopening is important, please see #3755 (comment)
Happy to close this pr if it turns out to not be needed