Hydrothermal conductivity with depth function with fastscape #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers, adjusted visco_plastic.h
…ers, adjusted visco_plastic.h
…ers, adjusted visco_plastic.h
…ers, adjusted visco_plastic.h
…djusted visco_plastic.h
…djusted visco_plastic.h
…djusted visco_plastic.h
…djusted visco_plastic.h
…djusted visco_plastic.h
…djusted visco_plastic.h
…djusted visco_plastic.h
…nverted from km to m)
…dBoelz/aspect into Hydrothermal_Conductivity
Remove comments and additional lines Add asserts
Second batch of squashed fastscape commits. Refactor saving/loading files for restart add paramters for erosional base level differing from sea level third batch of squashed fastscape commits. Expand on plugin description Fourth batch of squashed fastscape commits. Update include/aspect/mesh_deformation/fastscape.h Co-authored-by: Wolfgang Bangerth <[email protected]> Update comment Update reptitions types and add python script to rewrite fastscape visualizations with time. Add get_end_time function Update cookbook and add check in viscoplastic Update sediment rain times Update cmakelists Remove commented line Fix library link
…with naming parameters
…tent with naming parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Anne, this is my most recent branch, where the fastscape version and the depth with respect to the current surface is included.
I was not sure what to do in case the parameter 'Use depth of sea for hydrothermal cooling approximation' is set to true, but there is no mesh deformation. Because then nothing would change during the computation of the new thermal conductivity (because depth_of_sea = 0 && use_depth_of_sea = true). I just threw an error in this case.
I really tried to have a nice structure of the code, but we already have several cases to check, therefore, it wasn't too easy.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: