Another attempt

another-rex · Dec 11, 2023 · 7ab2780 · 7ab2780
1 parent 78087a9
commit 7ab2780
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/.github/workflows/osv-scanner-reusable-pr.yml b/.github/workflows/osv-scanner-reusable-pr.yml
@@ -34,9 +34,9 @@ on:
         default: results.sarif
       upload-sarif:
         description: "Whether to upload to Security > Code Scanning"
-        type: boolean
+        type: string # String type instead of boolean to workaround github action limitation (See https://github.com/actions/runner/issues/1483)
         required: false
-        default: false
+        default: "false"
 
 jobs:
   scan-pr:
@@ -99,7 +99,7 @@ jobs:
           retention-days: 5
       # Upload the results to GitHub's code scanning dashboard.
       - name: "Upload to code-scanning"
-        if: "false"
+        if: "!cancelled() && ${{ inputs.upload-sarif == 'true' }}"
         uses: github/codeql-action/upload-sarif@407ffafae6a767df3e0230c3df91b6443ae8df75 # v2.22.8
         with:
           sarif_file: ${{ inputs.results-file-name }}