Skip to content

Commit

Permalink
Merge pull request redpanda-data#115 from voutilad/fix-wasm-build
Browse files Browse the repository at this point in the history
Fix wasm build by stubbing noReread().
  • Loading branch information
mihaitodor authored Oct 24, 2024
2 parents 19ee60c + 40da7bf commit f423b1a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ All notable changes to this project will be documented in this file.
- Go API: Cli opt function added for custom CLI flags. (@Jeffail)
- Go API: Methods `HasStructured` and `HasBytes` added to the message type. (@rockwotj)

### Fixed

- WASM builds work again. (@voutilad)

### Changed

- CLI `--set` flags can now mutate array values indexed from the end via negative integers. E.g. `--set 'foo.-1=meow'` would set the last index of the array `foo` to the value of `meow`.
Expand Down
5 changes: 5 additions & 0 deletions internal/config/watcher_wasm.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,8 @@ import (
func (r *Reader) BeginFileWatching(mgr bundle.NewManagement, strict bool) error {
return errors.New("file watching is disabled in WASM builds")
}

// noReread is a no-op in WASM builds as the file watcher is not supported.
func noReread(err error) error {
return err
}

0 comments on commit f423b1a

Please sign in to comment.