Remove superfluous param from get_bin_path #109
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 73.00% 79.23% +6.23%
==========================================
Files 16 23 +7
Lines 1015 1445 +430
Branches 182 253 +71
==========================================
+ Hits 741 1145 +404
- Misses 243 258 +15
- Partials 31 42 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 23s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 07s |
The parameter `required` in process.get_bin_path is useless. Remove and update the usage of get_bin_path in inventory and lookup plugins. Signed-off-by: Abhijeet Kasurde <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 40s |
| try: | ||
| terraform_binary = process.get_bin_path("terraform") | ||
| except ValueError: | ||
| raise AnsibleParserError("Unable to find 'terraform' binary in the path") |
There was a problem hiding this comment.
This needs to be imported, first.
SUMMARY
The parameter
requiredin process.get_bin_path is useless.Remove and update the usage of get_bin_path in inventory and lookup
plugins.
Signed-off-by: Abhijeet Kasurde [email protected]
ISSUE TYPE