Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve preflight validation #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

findmyname666
Copy link

SUMMARY
  • Validate command should be run before terraform plan execution otherwise there is no point to do any validation.
  • Validation error produces ANSI escape codes. Therefore we should use -no-color argument, see this issue for more info.

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/36814bf4cfbf47c18c7937101faad8de

✔️ build-ansible-collection SUCCESS in 8m 53s
ansible-test-sanity-docker-devel FAILURE in 7m 28s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 6m 42s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 6m 33s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 32s
ansible-test-units-cloud-terraform-python38 FAILURE in 4m 34s
✔️ ansible-test-integration-cloud-terraform SUCCESS in 7m 32s
ansible-test-changelog FAILURE in 4m 36s
✔️ ansible-galaxy-importer SUCCESS in 3m 40s

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd97797) 73.23% compared to head (9b740eb) 34.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #52       +/-   ##
===========================================
- Coverage   73.23%   34.00%   -39.23%     
===========================================
  Files          16        9        -7     
  Lines        1005      641      -364     
  Branches      181      159       -22     
===========================================
- Hits          736      218      -518     
- Misses        238      423      +185     
+ Partials       31        0       -31     
Flag Coverage Δ
sanity 34.00% <ø> (ø)
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant