Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate/vmware host #110

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

Migrating the vmware_host functionality from community to this repo.
I split the module into two, one to manage if the host is added or removed from vcenter and one to manage if the host is connected or disconnected from vcenter (disconnecting is considered a temporary state while removing is more permenant).

I think having these two functions together made the module a bit more complicated than it needed to be.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

esxi_host
esxi_connection

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 27.35849% with 154 lines in your changes missing coverage. Please review.

Project coverage is 28.05%. Comparing base (f01d665) to head (5762f16).

Files with missing lines Patch % Lines
plugins/modules/esxi_host.py 23.37% 118 Missing ⚠️
plugins/modules/esxi_connection.py 37.93% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   28.10%   28.05%   -0.05%     
==========================================
  Files          40       42       +2     
  Lines        3277     3489     +212     
  Branches      622      662      +40     
==========================================
+ Hits          921      979      +58     
- Misses       2356     2510     +154     
Flag Coverage Δ
sanity 28.05% <27.35%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant