Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deploy content modules when library name is not provided #111

Merged

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

Fixes issue where an error is thrown if the user does not provide the option library_name parameter
New functionality will mean all libraries are searched if the name is not provided

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

deploy_content_library_ovf
deploy_content_library_template

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.08%. Comparing base (f01d665) to head (314e937).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...odule_utils/_module_deploy_content_library_base.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   28.10%   28.08%   -0.02%     
==========================================
  Files          40       40              
  Lines        3277     3279       +2     
  Branches      622      623       +1     
==========================================
  Hits          921      921              
- Misses       2356     2358       +2     
Flag Coverage Δ
sanity 28.08% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemorency mikemorency merged commit 01bc7dc into ansible-collections:main Feb 9, 2025
10 of 13 checks passed
@mikemorency mikemorency deleted the bugfix/deploy-content-ovf branch February 9, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants