AAP-36632-update: TOC restructure of Ansible Lightspeed User Guide #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayjadha
force-pushed
the
AAP-36632-update
branch
from
dc3a564 to
6954efd
Compare
sayjadha
added
Ready for review
lightspeed/assemblies/assembly_administering-ansible-lightspeed.adoc
Outdated
Show resolved
Hide resolved
lightspeed/assemblies/assembly_administering-ansible-lightspeed.adoc
Outdated
Show resolved
Hide resolved
| You cannot disable collection of operational telemetry data. Operational telemetry data includes only data that is necessary to operate and troubleshoot the service. However, you can disable the collection of Admin Dashboard telemetry data. For more information, see xref:disable-admin-dashboard-telemetry_administering-ansible-lightspeed[Disabling the Admin dashboard telemetry]. |
There was a problem hiding this comment.
Just an ignorable suggestion: - not very important.
The nesting level of these sections is quite deep - 1.4.4.2.5. Maybe consider non-indexed headings for these short sections, or putting them in a Definition list.
There was a problem hiding this comment.
I edited the section titles to discrete headings (reference: https://docs.asciidoctor.org/asciidoc/latest/blocks/discrete-headings/). It looks okay in asciidoctor output but a tad bit smaller in ccutil output. If this edit is okay with you, let's see how it renders in the output and then update if required?
jself-sudoku
reviewed
Feb 8, 2025
lightspeed/modules/con_view-manage-admin-dashboard-telemetry.adoc
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses JIRA https://issues.redhat.com/browse/AAP-36632.
Changes made: